facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Remove various args from InteractionPlot.__init__ #3096

Closed mpolson64 closed 13 hours ago

mpolson64 commented 1 day ago

Summary: Simplifying InteractionPlot by removing some arguments from its initializer. IMO the typical user just wants to specify a metric (or have the appropriate metric selected for them) and run compute. In some cases an advanced user may want to decide whether or not to plot interactions, but by default we should.

No matter what we should always show the bar chart displaying relative importance of each parameter and the top 6 slices/surfaces.

If this simplifications seem appropriate then I will continue to refactor the InteractionPlot's code to take advantage of this removed flexibility.

Removals:

The following diffs will restructure the code here to take advantage of the simplified options

Differential Revision: D65148289

facebook-github-bot commented 1 day ago

This pull request was exported from Phabricator. Differential Revision: D65148289

facebook-github-bot commented 1 day ago

This pull request was exported from Phabricator. Differential Revision: D65148289

facebook-github-bot commented 1 day ago

This pull request was exported from Phabricator. Differential Revision: D65148289

codecov-commenter commented 1 day ago

Codecov Report

Attention: Patch coverage is 94.53925% with 16 lines in your changes missing coverage. Please review.

Project coverage is 95.42%. Comparing base (4aa1d65) to head (2704529).

Files with missing lines Patch % Lines
ax/analysis/plotly/surface/utils.py 57.14% 9 Missing :warning:
ax/analysis/plotly/surface/contour.py 93.61% 3 Missing :warning:
ax/analysis/plotly/interaction.py 97.59% 2 Missing :warning:
ax/analysis/plotly/surface/slice.py 95.91% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3096 +/- ## ========================================== - Coverage 95.43% 95.42% -0.01% ========================================== Files 495 503 +8 Lines 49956 50249 +293 ========================================== + Hits 47674 47952 +278 - Misses 2282 2297 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

facebook-github-bot commented 15 hours ago

This pull request was exported from Phabricator. Differential Revision: D65148289

facebook-github-bot commented 15 hours ago

This pull request was exported from Phabricator. Differential Revision: D65148289

facebook-github-bot commented 15 hours ago

This pull request was exported from Phabricator. Differential Revision: D65148289

facebook-github-bot commented 13 hours ago

This pull request has been merged in facebook/Ax@8fe3fed3bdffd526330138ac65a9c25eeb6e4748.