Closed mpolson64 closed 13 hours ago
This pull request was exported from Phabricator. Differential Revision: D65148289
This pull request was exported from Phabricator. Differential Revision: D65148289
This pull request was exported from Phabricator. Differential Revision: D65148289
Attention: Patch coverage is 94.53925%
with 16 lines
in your changes missing coverage. Please review.
Project coverage is 95.42%. Comparing base (
4aa1d65
) to head (2704529
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
This pull request was exported from Phabricator. Differential Revision: D65148289
This pull request was exported from Phabricator. Differential Revision: D65148289
This pull request was exported from Phabricator. Differential Revision: D65148289
This pull request has been merged in facebook/Ax@8fe3fed3bdffd526330138ac65a9c25eeb6e4748.
Summary: Simplifying InteractionPlot by removing some arguments from its initializer. IMO the typical user just wants to specify a metric (or have the appropriate metric selected for them) and run compute. In some cases an advanced user may want to decide whether or not to plot interactions, but by default we should.
No matter what we should always show the bar chart displaying relative importance of each parameter and the top 6 slices/surfaces.
If this simplifications seem appropriate then I will continue to refactor the InteractionPlot's code to take advantage of this removed flexibility.
Removals:
The following diffs will restructure the code here to take advantage of the simplified options
Differential Revision: D65148289