facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Build pypi packages with build #3098

Closed Balandat closed 23 hours ago

Balandat commented 1 day ago

Invoking python setup.py sdist bdist_wheel to build the packages is deprecated. This instead uses the PEP517-compliant build frontend build as per https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/

This also fixes an issue with PEP 625 non-compliance (before this change, the source distribuiton filename would be ax-platform-x.x.x.tar.gz; when using build as in this change the first hyphen gets properly normalized to an underscore).

facebook-github-bot commented 1 day ago

@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

codecov-commenter commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.74%. Comparing base (1efbcbd) to head (bff6794).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3098 +/- ## ======================================= Coverage 95.74% 95.74% ======================================= Files 488 488 Lines 49769 49769 ======================================= Hits 47653 47653 Misses 2116 2116 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

facebook-github-bot commented 23 hours ago

@Balandat merged this pull request in facebook/Ax@be8bb34f4fd2a6ebec790a2923733c2236bc2cd8.