facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Simplified and optimized logic for calculating per-metric subsampling rate for MapData #3106

Open ltiao opened 3 days ago

ltiao commented 3 days ago

Differential Revision: D66366076

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D66366076

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D66366076

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D66366076

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D66366076

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D66366076

codecov-commenter commented 2 days ago

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.43%. Comparing base (4127865) to head (b7b8491).

Files with missing lines Patch % Lines
ax/core/observation.py 87.50% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3106 +/- ## ========================================== + Coverage 95.42% 95.43% +0.01% ========================================== Files 503 503 Lines 50264 50255 -9 ========================================== - Hits 47965 47962 -3 + Misses 2299 2293 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: