facebook / Ax

Adaptive Experimentation Platform
https://ax.dev
MIT License
2.38k stars 312 forks source link

Refer to "time interval" to "step" in benchmarking; give `BenchmarkTestFunction` an "step" attribute #3110

Closed esantorella closed 1 hour ago

esantorella commented 1 day ago

Summary: I find this clearer, since "time interval" is vauge and could in theory refer to many different periods of time. The downside is that "epoch" may make less sense outside the context of AutoML.

The new attribute is not needed yet, but will be in the next diff.

Differential Revision: D66397779

facebook-github-bot commented 1 day ago

This pull request was exported from Phabricator. Differential Revision: D66397779

codecov-commenter commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.43%. Comparing base (7f2c4a0) to head (1e991b5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3110 +/- ## ======================================= Coverage 95.43% 95.43% ======================================= Files 503 503 Lines 50264 50267 +3 ======================================= + Hits 47967 47970 +3 Misses 2297 2297 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

facebook-github-bot commented 1 day ago

This pull request was exported from Phabricator. Differential Revision: D66397779

facebook-github-bot commented 6 hours ago

This pull request was exported from Phabricator. Differential Revision: D66397779

facebook-github-bot commented 4 hours ago

This pull request was exported from Phabricator. Differential Revision: D66397779

facebook-github-bot commented 1 hour ago

This pull request has been merged in facebook/Ax@3327deeab2a8b0cd6b7e15ecdd8a3d527fc863f2.