search

facebook / CacheLib

Pluggable in-process caching engine to build and scale high performance services
https://www.cachelib.org
Apache License 2.0
1.18k stars 256 forks source link

[Fix] update docx in user guide #224

Closed zztaki closed 1 year ago

zztaki commented 1 year ago

In Remove_data_from_cache.md, std::memcpy(handle->getMemory(), itr.first.data(), itr.second.size()); write the content of key to handle wrongly in Line72, we should write the content of value.

facebook-github-bot commented 1 year ago

Hi @zztaki!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

zztaki commented 1 year ago

I also fix some confusing statements in Write_data_to_cache.md and Read_data_from_cache.md

facebook-github-bot commented 1 year ago

@haowu14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@haowu14 merged this pull request in facebook/CacheLib@a7fa0b99f5e0197ccbe60d48b87a5316639e13ee.