Closed dkruces closed 1 year ago
Manually executing cd cachelib/benchmarks && /cachelib/opt/cachelib/bin/thrift1 -o /cachelib/build-cachelib/cachelib/benchmarks/ --gen mstch_cpp2:frozen2 -I /cachelib/cachelib/.. -I /cachelib/cachelib/external/fbthrift DataTypeBench.thrift
workarounds the issue.
root@97cb6ebf98ed:/cachelib# cd cachelib/benchmarks && /cachelib/opt/cachelib/bin/thrift1 -o /cachelib/build-cachelib/cachelib/benchmarks/ --gen mstch_cpp2:frozen2 -I /cachelib/cachelib/.. -I /cachelib/cachelib/external/fbthrift DataTypeBench.thrift
[WARNING:DataTypeBench.thrift:22] Required field is deprecated: `m`.
[WARNING:DataTypeBench.thrift:26] Required field is deprecated: `m`.
root@97cb6ebf98ed:/cachelib# ./contrib/build.sh -d -j -v
...
[100%] Built target cachebench
make[1]: Leaving directory '/cachelib/build-cachelib'
/usr/bin/cmake -E cmake_progress_start /cachelib/build-cachelib/CMakeFiles 0
make -f CMakeFiles/Makefile2 preinstall
make[1]: Entering directory '/cachelib/build-cachelib'
make[1]: Nothing to be done for 'preinstall'.
make[1]: Leaving directory '/cachelib/build-cachelib'
Install the project...
/usr/bin/cmake -P cmake_install.cmake
-- Install configuration: "Debug"
-- Installing: /cachelib/opt/cachelib/include/cachelib/allocator
-- Installing: /cachelib/opt/cachelib/include/cachelib/allocator/memory
...
-- Installing: /cachelib/opt/cachelib/test_configs/consistency/navy-with-deletes-with-truncated-alloc-size.json
-- Installing: /cachelib/opt/cachelib/test_configs/consistency/navy-with-deletes-stack-alloc-inmem-buf.json
-- Installing: /cachelib/opt/cachelib/test_configs/simple_test_with_persistence.json
-- Installing: /cachelib/opt/cachelib/lib/cmake/cachelib/cachelib-targets.cmake
-- Installing: /cachelib/opt/cachelib/lib/cmake/cachelib/cachelib-targets-debug.cmake
-- Installing: /cachelib/opt/cachelib/lib/libcachelib_common.a
-- Installing: /cachelib/opt/cachelib/lib/libcachelib_shm.a
-- Installing: /cachelib/opt/cachelib/lib/libcachelib_navy.a
-- Installing: /cachelib/opt/cachelib/lib/libcachelib_allocator.a
-- Installing: /cachelib/opt/cachelib/lib/libcachelib_datatype.a
-- Installing: /cachelib/opt/cachelib/bin/cachebench
'cachelib' is now installed
Hi @dagmcr
Thanks for reporting the bug and the workaround. This is caused by eee2913237b0 (fbcode/cachelib/) and we are working on the fix.
I will let you know once this is fixed.
The offending change had been reverted, so let me close this.
Describe the bug Cachelib build (install benchmark) error when using the wrapper command:
./contrib/build.sh -d -j -v
To Reproduce
debian:10
).3d475f673a5e1bd5db776c8cb7f2666c9694f7dd
) or the latest tagv2023.04.17.00
.contrib/build.sh
script.Expected behavior Build succeeds.
Logs
Desktop: