search

facebook / CacheLib

Pluggable in-process caching engine to build and scale high performance services
https://www.cachelib.org
Apache License 2.0
1.21k stars 262 forks source link

Segmentation Fault when trying to run Cachebench #28

Closed jeffreyalien closed 3 years ago

jeffreyalien commented 3 years ago

I was able add support for Western Digital drives by adding the wdcWriteBytes function to the NandWrites.cpp part. I believe that code is working as expected but we're getting a Segmentation Fault when trying to run cachebench. We’re using a json file that we got from Facebook but not sure if that’s what we should be using or if it needs some updates. I’ve attached it along with the runtime log to the issue. We are new to the cachebench app so hopefully it’s something simple with our config or setup.

runtime-job-log.txt tao_leader_t10.txt

agordon commented 3 years ago

@jeffreyalien To verify: are you using the latest git version of cachelib ? this looks very similar to a bug that was fixed last week ( internal ref: D30050023 )

sathyaphoenix commented 3 years ago

@jeffreyalien yeah, this was broken for a brief period of time as we were preparing the repository for Open source. We squashed all the commits in preparation, so I can't point you to the exact fix. But, if you pull from main branch, it should go away. Also, please note that the repository has changed a bit in terms of the setup in preparation for OSS. So you might want to clone from scratch to avoid any issues instead of pulling from the old checkout.

jeffreyalien commented 3 years ago

The latest code is running now - no seg fault with it. I will create a PR with my changes to add support for the wdcWriteBytes function.

jeffreyalien commented 3 years ago

Fixed with the latest CacheLib clone.

sathyaphoenix commented 3 years ago

@jeffreyalien perfect. thanks for confirming. Look forward to the PR :)