search

facebook / CacheLib

Pluggable in-process caching engine to build and scale high performance services
https://www.cachelib.org
Apache License 2.0
1.18k stars 254 forks source link

Adding Unit Tests for FdpNvme class #318

Closed arungeorge83 closed 1 month ago

arungeorge83 commented 3 months ago

This commit adds the unit test cases for "FdpNvme" class. It also adds a new constructor for FdpNvme. The existing constructor of FdpNvme communicates with the actual FDP device and makes the unit tests impossible to run without the actual device. So this commit adds a new constructor which allows to experiment with "FdpNvme" without the actual FDP device.

facebook-github-bot commented 2 months ago

@haowu14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 months ago

@arungeorge83 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 month ago

@haowu14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@arungeorge83 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 month ago

@haowu14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@haowu14 merged this pull request in facebook/CacheLib@e974ed6412414381c2e46006a85154ac85b7dafc.