facebook / CacheLib

Pluggable in-process caching engine to build and scale high performance services
https://www.cachelib.org
Apache License 2.0
1.21k stars 261 forks source link

Build issue with CacheLib with missing source files #320

Closed sairahul-chalamalasetti closed 3 months ago

sairahul-chalamalasetti commented 4 months ago

Describe the bug While building cachelib on Ubuntu 22.04 and kernel 6.7.0-060700-generic got errors for missing source files from benchmarks folder . To Reproduce Steps to reproduce the behavior: During build instructions provided at ./contrib/build.sh -j -T

Expected behavior Get CMAKE Error

-- Configuring done CMake Error at CMakeLists.txt:134 (add_executable): Cannot find source file:

BinarySearchVsHashTableBench.cpp

Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc Call Stack (most recent call first): benchmarks/CMakeLists.txt:34 (generic_add_test) benchmarks/CMakeLists.txt:38 (add_test)

CMake Error at CMakeLists.txt:134 (add_executable): Cannot find source file:

CachelibMapOperationBench.cpp

Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc Call Stack (most recent call first): benchmarks/CMakeLists.txt:34 (generic_add_test) benchmarks/CMakeLists.txt:41 (add_test)

CMake Error at CMakeLists.txt:134 (add_executable): Cannot find source file:

CachelibMapWorkloadBench.cpp

Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc Call Stack (most recent call first): benchmarks/CMakeLists.txt:34 (generic_add_test) benchmarks/CMakeLists.txt:42 (add_test)

CMake Error at CMakeLists.txt:134 (add_executable): Cannot find source file:

CachelibRangeMapWorkloadBench.cpp

Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc Call Stack (most recent call first): benchmarks/CMakeLists.txt:34 (generic_add_test) benchmarks/CMakeLists.txt:43 (add_test)

CMake Error at CMakeLists.txt:134 (add_executable): No SOURCES given to target: benchmark-test-BinarySearchVsHashTableBench Call Stack (most recent call first): benchmarks/CMakeLists.txt:34 (generic_add_test) benchmarks/CMakeLists.txt:38 (add_test)

CMake Error at CMakeLists.txt:134 (add_executable): No SOURCES given to target: benchmark-test-CachelibMapOperationBench Call Stack (most recent call first): benchmarks/CMakeLists.txt:34 (generic_add_test) benchmarks/CMakeLists.txt:41 (add_test)

CMake Error at CMakeLists.txt:134 (add_executable): No SOURCES given to target: benchmark-test-CachelibMapWorkloadBench Call Stack (most recent call first): benchmarks/CMakeLists.txt:34 (generic_add_test) benchmarks/CMakeLists.txt:42 (add_test)

CMake Error at CMakeLists.txt:134 (add_executable): No SOURCES given to target: benchmark-test-CachelibRangeMapWorkloadBench Call Stack (most recent call first): benchmarks/CMakeLists.txt:34 (generic_add_test) benchmarks/CMakeLists.txt:43 (add_test)

CMake Generate step failed. Build files cannot be regenerated correctly. build-package.sh: error: cmake failed on cachelib build.sh: error: failed to build cachelib

therealgymmy commented 4 months ago

We removed these files but didn't remove from our oss cmakefiles. Will send out a fix shortly.

therealgymmy commented 3 months ago

@sairahul-chalamalasetti Hi, can you check if the builds work for you now?

sairahul-chalamalasetti commented 3 months ago

The build works now. Thanks for fixing it !!