search

facebook / IT-CPE

Meta's Client Platform Engineering tools. Some of the tools we have written to help manage our fleet of client systems.
Apache License 2.0
559 stars 117 forks source link

cpe_chrome does not require dependency on fb_osquery #261

Open johnnyramos opened 3 years ago

johnnyramos commented 3 years ago

Seems a dependency was added in this commit but I don't see the requirement for it in the code.

Line: https://github.com/facebook/IT-CPE/blob/91a35df19062026a5531ff4c1ae024bb92e3e333/itchef/cookbooks/cpe_chrome/metadata.rb#L13

ChefAustin commented 3 years ago

Furthermore, (even if the dependency were necessary) fb_osquery is not offered in either this repo or facebook/chef-cookbooks.

steelcowboy commented 3 years ago

Sorry about this oversight, unfortunately it is actually required: node.installed? comes from fb_osquery: https://github.com/facebook/IT-CPE/blob/d001ffc64d1246c952392f3184c97afb8e5f1fe6/itchef/cookbooks/cpe_chrome/resources/cpe_chrome_win.rb#L30

fb_osquery was intended to be open-sourced, I will see if there are any blockers to doing that and update this issue once it is done

erikng commented 3 years ago

I'm sure you're unlikely to use our cookbook but we've had a API style osquery cookbook open sourced for about a year.

https://github.com/uber/client-platform-engineering/tree/main/chef/cookbooks/cpe_osquery

johnnyramos commented 3 years ago

Just following up @steelcowboy - thanks!

steelcowboy commented 2 years ago

Sorry it took me a while to follow up on this! I'm in the process of open sourcing fb_osquery and I expect I'll have it done in the next few days