search

facebook / PathPicker

PathPicker accepts a wide range of input -- output from git commands, grep results, searches -- pretty much anything. After parsing the input, PathPicker presents you with a nice UI to select which files you're interested in. After that you can open them in your favorite editor or execute arbitrary commands.
https://facebook.github.io/PathPicker/
MIT License
5.11k stars 283 forks source link

Demo videos in homepage not loading on mobile #407

Open code-reaper08 opened 3 years ago

code-reaper08 commented 3 years ago

Describe the bug Demo videos in homepage are not visible and leave a blank space in mobile browsers. To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://facebook.github.io/PathPicker/' using mobile.
  2. Videos there don't display and leaves a space.

Expected behavior The demo videos could have a fallback on mobile browsers, which makes them an image redirecting to the actual video demo.

Screenshots in mobile browser demo_video_missing in desktop browser demo_video_present

Desktop:

Smartphone:

Additional context I am working on this issue currently and would make a PR in a couple of days. if you don't mind please assign this to me. Thanks in advance 😄

KapJI commented 3 years ago

I checked it in Safari on iPhone and there it works fine. Probably only Android is affected?

code-reaper08 commented 3 years ago

I checked it in Safari on iPhone and there it works fine. Probably only Android is affected?

Thanks for your reply @KapJI Most probably YES if it works on Safari, Only android is affected. Is there anything we can do?

BTW I am not sure what causes this issue 😕

Tried implementing a fallback for mobile devices to make the video as an image, sadly that too is not rendered.