search

facebook / PathPicker

PathPicker accepts a wide range of input -- output from git commands, grep results, searches -- pretty much anything. After parsing the input, PathPicker presents you with a nice UI to select which files you're interested in. After that you can open them in your favorite editor or execute arbitrary commands.
https://facebook.github.io/PathPicker/
MIT License
5.11k stars 283 forks source link

remove homebrew formula #416

Closed thiagowfx closed 2 years ago

thiagowfx commented 2 years ago

It is already maintained upstream: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/fpp.rb

thiagowfx commented 2 years ago

By the way, you may want to bump it upstream to 0.9.5

pcottle commented 2 years ago

I think I had the formula in here for easy copying when we need to update the recipe upstream

So removing the file might break this build: https://github.com/facebook/PathPicker/blob/main/scripts/makeDist.sh#L11

since we need the template

thiagowfx commented 2 years ago

Did you use this script when you created 0.9.5?

My take is that you don’t need to worry about it; packaging and upgrades are usually deferred to the community. Deleting the script would make your life as a maintainer easier by making it explicit the package isn’t maintained from this repo.

That said, this is just a suggestion. Keeping the script around certainly won’t hurt.

thiagowfx commented 2 years ago

I’ll go ahead and close this then, but if you change your mind I could also remove the script you mentioned before submitting this PR.