search

facebook / Rapid

The OpenStreetMap editor driven by open data, AI, and supercharged features
https://rapideditor.org
ISC License
515 stars 91 forks source link

Wrong fix for crossing:markings=zebra;dots #1355

Open Martinligabue opened 6 months ago

Martinligabue commented 6 months ago

Description

crossing:markings=zebra;dots should be legal, but the editor suggests "upgrading the tags" by simply removing "dots", leaving it as crossing:markings=zebra

It is however a correct syntax, as stated in https://wiki.openstreetmap.org/wiki/Key:crossing:markings#Examples

Screenshots

immagine

Version

2.2.5

What browser are you seeing the problem on? What version are you running?

Firefox v115.0

The OS you're using

arch, btw

Steps to reproduce

  1. make a crossing with this tag "crossing:markings=zebra;dots"
  2. rapid will complain

The browser URL at the time you encountered the bug

https://rapideditor.org/edit#background=Bing&datasets=fbRoads,msBuildings&disable_features=buildings,landuse,boundaries&map=21.16/44.77937/10.78473

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

bhousel commented 6 months ago

It is probably offering that suggestion because that node also has the crossing=zebra tag. I’m not sure if we will be able to support the semicolon delimited values as well as the plain values.