facebook / Rapid

The OpenStreetMap editor driven by open data, AI, and supercharged features
https://rapideditor.org
ISC License
515 stars 91 forks source link

Editing Conflicts between users do not get solved after several minutes awaiting #1361

Open jjiglesiasg opened 6 months ago

jjiglesiasg commented 6 months ago

Description

For unknowm reason Rapid marked an editing conflict between editors. The app starts a loop of awaiting but nothing happens.

So you need to reset, them 36 editions are lost, and more than 1000 nodes trashed.

Screenshots

Screenshot (188)

Version

2.2.5

What browser are you seeing the problem on? What version are you running?

EDGE Version 120.0.2210.91 (Official build) (64-bit)

The OS you're using

No response

Steps to reproduce

No idea how to reproduce, I do have the idea that at least 1 hour of work is lost.

The rate of Failure of Rapid is exponentially bigger than ID

The browser URL at the time you encountered the bug

No URL possible from the App

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

No response

jjiglesiasg commented 6 months ago

![Uploading Screenshot (189).png…]()

bhousel commented 6 months ago

Thanks for reporting - this is an issue in the old uploading code we inherited from iD.
I thought I had improved on this last year, but I'll need to dig into it some more and see what's going on. It's a tricky problem to diagnose because it depends on the user causing a conflict when editing with certain things that are difficult to conflict check (Relations, usually).

To do the conflict check, we need to download all the affected features from OSM and check each one.

jjiglesiasg commented 6 months ago

Thanks Bryan in this case in particular, there were no relations involved, as far as I know.

Really is disturbing that uploading is becoming a guessing game, where you don't know if your work will be saved or just lost...

eneerhut commented 3 weeks ago

Related to https://github.com/facebook/Rapid/issues/1480.