facebook / Rapid

The OpenStreetMap editor driven by open data, AI, and supercharged features
https://rapideditor.org
ISC License
515 stars 91 forks source link

Improve UI to select tag conflicts #1367

Open tordans opened 6 months ago

tordans commented 6 months ago

Description

In https://github.com/facebook/Rapid/issues/1260#issuecomment-2041070226 we talked about the tag conflict UI which does not present the diffs per option.

This is not ideal because…


One idea to fix this would be to give a separate "show diff" action per option which then updates the diff. And one way to do this would be to move the diff in a details html element inside the options list. In this case, the diff would be closed for all at first, but the label could be something like "Show changes for this action" which should explain itself quite well.

Some very hacky screenshots to illustrate this idea:


Another idea in the same spirit would be to have a secondary button per option that updates the diff section below. That would mean the diff section can stay open as it is now and only the diff-section headline has to change (to clarify the relation to the option).

bhousel commented 6 months ago

I've heard feedback before that it would be better if the issue fixes were radio buttons, that way the user could make a choice before performing the action. Right now each issue fix is a button that pefroms the action so it doesn't give the user the chance to consider what the different options do.