search

facebook / Rapid

The OpenStreetMap editor driven by open data, AI, and supercharged features
https://rapideditor.org
ISC License
503 stars 92 forks source link

OSM data not loading in Rapid #1424

Open eneerhut opened 3 months ago

eneerhut commented 3 months ago

Description

This issue is happening to me fairly frequently in Rapid. I zoom into an area to start mapping, but not all of the OSM data for that area loads. Sometimes none of it loads.

In some cases a refresh causes the data to load successfully, but not always. When mapping in an area I am less familiar with, missing OSM data can cause me to duplicate data that is already there, but not visible in Rapid. This undermines confidence in Rapid and causes me to check other editors.

Screenshots

https://github.com/facebook/Rapid/assets/11349863/d23f6ea0-bc37-42cc-9f0c-386128b05e42

Version

2.3.1

What browser are you seeing the problem on? What version are you running?

Version 124.0.6367.158 (Official Build) (arm64)

The OS you're using

macOS 14.4.1 (23E224)

Steps to reproduce

Zoom to an area with bing imagery layer enabled. Wait for data to load.

The browser URL at the time you encountered the bug

https://rapideditor.org/edit#map=20.10/37.55529/-122.27505&background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

No response

bhousel commented 3 months ago

I did investigate a bit, and I am able to load data from around there, but this Foster City / Redwood Shores area is very densely mapped, so it would not surprise me if you are hitting a rate limit from OSM.

This looks pretty similar to the issues you reported on #1304..

Screenshot 2024-05-13 at 3 39 20 PM

Not sure the best way to approach this issue - As OSM grows, this will probably be more of an problem.

mmd-osm commented 3 months ago

I also noticed the same, and believe it coincidences with the introduction of mod_evasive on the osm server a few months back. More specifically, this Apache module has been enabled on Mar 12, 2024.

It would be good to know if you see OPTIONS preflight requests failing in your browser console with something like "CORS header 'Access-Control-Allow-Origin' missing".

Typical symptoms would be that only parts of the map are loaded, and when panning the map after a while, these missing parts would start showing up. In particular I've seen this issue when you start mapping in a densely mapped area and start out with a low zoom level, then keep on zooming in to a neighborhood. This triggers a large number of (parallel) requests to the osm server. which seems to trigger mod_evasive in some cases.

In my case mod_evasive kicked in before 509 rate limit error was even reported. Rapid would not report any issues there, in particular no message like "Please try again in x seconds". Some of the improvements in #1304 don't seem to work anymore at the moment.

Let's try to collect some more details before reporting it on the osm operations issue tracker.

bhousel commented 3 months ago

It would be good to know if you see OPTIONS preflight requests failing in your browser console with something like "CORS header 'Access-Control-Allow-Origin' missing".

I definitely have seen these, and wondered about it - it's a pretty weird error, especially if things end up working eventually.

mmd-osm commented 2 weeks ago

So now that mod_evasive is no longer enabled (see https://github.com/openstreetmap/operations/issues/1085#issuecomment-2276110694), I'd suggest to keep monitoring if the previous issues are still showing up.