Maproulette "submit" button not working.

atiannicelli commented 4 months ago

Description

When I try to complete a MapRoulette task using the new MapRoulette integration it is not working for me. I can do everything else, but when I clisk submit nothing happens.

Screenshots

Version

2.3.1

What browser are you seeing the problem on? What version are you running?

Chrome v125.0

The OS you're using

mac

Steps to reproduce

go to the link listed and then set the mapRoulette challenge id to 43759 then you should see a couple tasks... click on one and then set to "not an issue" and then click submit.... nothing happens.

The browser URL at the time you encountered the bug

https://rapideditor.org/edit#map=21.64/47.60380/-122.33598&background=Mapbox&datasets=fbRoads,msBuildings&disable_features=boundaries&photo_overlay=streetside

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36

bhousel commented 4 months ago

Ah thanks @atiannicelli - I heard a rumor that MapRoulette cycled their API keys this week and people might need to log out of MapRoulette and back into it, to get things working again. The code in Rapid probably does not account for the possiblity of the key changing, so we'll see if we can handle it better.

tannerwuster commented 4 months ago

Hi @atiannicelli - a pull request has been submitted to address the issue reported here regarding the MapRoulette integration. Even after resting the API it still won’t work until this PR is accepted on MapRoulette PR #1127.

tsmock commented 4 months ago

For everyone who is pointed here:

MR 4.5.0 had an upgrade to a library that caused "secrets" to be encrypted in the DB.
MR < 4.5.1 also had a problem where the old API key generated by clicking on Reset in the MR user profile ( https://maproulette.org/user/profile ) would put the old API key in OSM user preferences instead of the new api key. You could work around this by logging out and back into MapRoulette.

There is no programmatic way for us (as MR API consumers) to reset the API key without a current API key.

If you (as a user) as encountered this problem, you can "fix" it by doing the following:

Got to https://maproulette.org/user/profile as the editing user (whatever you are logged in as via Rapid or JOSM)
Scroll to the bottom of the page
Hit Reset
Go back to your editor and try again. If it still fails, you may be experiencing an issue where MR isn't putting the new key in OSM preferences. If you encounter this, additional work may be required.

I have asked on #maproulette-dev if it would be possible to run something like UPDATE users SET api_key = null WHERE api_key NOT LIKE '1414|%'; on the DB so we just have to get users to log in to MR instead of also needing to Reset their API keys.

bhousel commented 2 months ago

Hey @atiannicelli , I think #1428 fixed this Can you confirm that things are working in the current Rapid release on https://rapideditor.org/rapid (v2.3.2)

atiannicelli commented 2 months ago

@bhousel yes, I had to refresh my Maproulete API and then logout of rapid and maproulette and then things started working.

facebook / Rapid