facebook / Rapid

The OpenStreetMap editor driven by open data, AI, and supercharged features
https://rapideditor.org
ISC License
492 stars 92 forks source link

Consider adding validation to create kerb nodes. #1460

Open Bonkles opened 2 months ago

Bonkles commented 2 months ago

Description

While mapping sidewalks and crossings, we should consider adding automagic validations for creating kerb nodes wherever crossing ways meeting sidewalks.

We could also consider a power user feature that would just create the kerb nodes with extreme prejudice. According to chad and Said, there is basically never going to be a sidewalk / crossing way intersection without a kerb node needing to be there.

Ex: This user is in the process of drawing a crossing way and has left it close to the sidewalk, and rapid has generated a lint showing the fact that they should probably be connected.

image

After connecting the two features, we should at least put up a lint saying that there should probably be a kerb node here:

image
tordans commented 2 months ago

+1 for looking for ways to automate adding kerbs!

After connecting the two features, we should at least put up a lint saying that there should probably be a kerb node here

I think this touches the area of local conventions on how to map sidewalks. In Berlin we would never join the three lines at the kerb but have the crossing reach into the sidewalk area as a link. The kerb is then on this crossing part. And even this mapping style is "controversial" locally with people splitting the crossing section. Example: image

However, maybe this can be simpler with a yellow hint…

This crossing has no kerb notes. Add kerb notes (and position them afterwards) Ignore

The yellow box could just place some notes with the right tags on the line and the user can then position them at the right place.

bhousel commented 2 months ago

This is a good suggestion - We just got back from State of the Map US, and there were something like 6 talks on sidewalk mapping. It's good that there is a Pedestrian Working Group now, and that they are starting to put together some guidance on how to map these features in a way that's most useful for consumers.

We should probably just do whatever @geocruizer and the working group ends up recommending, after they've had some time to discuss among themselves.

Bonkles commented 2 months ago

Team discussed- here's what we're proposing for our first cut.

Should we offer different fixes in the validation pane?

tordans commented 2 months ago

Team discussed- here's what we're proposing for our first cut.

That sounds like a good plan!

Should we offer different fixes in the validation pane?

That will add a bit more complexity … and apps like StreetComplete are great at adding this data later, if it where missing.


Another thing that might be interesting:

We have this double tagging of kerb=* on the crossing node whenever no separate sidewalks but crossings are present. Rapid recently added the validation that syncs tags. Can there be a warning when the crossing node and the kerb nodes on the crossing way do not match?


(Sidenote: Crossings have this added complexity of having crossing nodes and crossing ways. I suggest to always add that for clarity.)

bhousel commented 2 months ago

We have this double tagging of kerb=* on the crossing node whenever no separate sidewalks but crossings are present. Rapid recently added the validation that syncs tags. Can there be a warning when the crossing node and the kerb nodes on the crossing way do not match?

I'm not sure if I am familiar with this style of mapping.. I wouldn't recommend for people to add a kerb= tag on a node anywhere except where the kerb actually is - anything else would likely lead to confusion.

tordans commented 2 months ago

I'm not sure if I am familiar with this style of mapping.. I wouldn't recommend for people to add a kerb= tag on a node anywhere except where the kerb actually is - anything else would likely lead to confusion.

It is confusing, I agree. My understanding of the usage is…

Other signals