Make Mapillary detections actually selectable

[bhousel]

We have a lot of old issues related to working with the Mapillary detections.

For context, viewing these detections on the map as markers (detected objects and street signs) is a feature that has been around since the iD days, but actually working with these detections is clumsy.

1502 - Detected objects in the Mapillary viewer have lost their styling

1113 - Show which images contain a particular detection (I am highlighting them yellow now)

944 - Make Mapillary Objects addable (maybe also #1127?)

897 - Missing Label Popups (the user can not see what the detected object actually is)

686 - Collect 👍 / 👎 feedback on Mapillary detections

528 / #1024 - The old "Add Mapillary Features" experiment that we lost during the V2 rewrite

As a first step towards closing out some of this old work, today I made the detections actually selectable.

This means - these detections finally work like all the other selectable things in Rapid (features, QA Items, Rapid stuff, custom data):

• If you click a detection, you're put into Select mode. (other things are unselected)
• The thing you selected gets drawn with a dashed-line select halo
• Information about this thing appears in the inspector/sidebar (for now I'm just showing First Seen / Last Seen details)
• The selected detection and layer are stored in the url hash (and it responds to changes in the url hash if you delete or change it manually)
• When you click empty map, you're returned to Browse mode

Followup ideas

• We now have a whole sidebar's worth of space to show more information about the detection, or flip through images, or supply feedback about the detection, or create the Add/Ignore flow to convert the detection to an OSM feature.
• The object icons are pretty bad, I will clean them up another time. We could really just map each of these detection categories to an OSM key/value and use the existing PresetSystem to pick reasonable icons.
• (Replacing the icons would also mean one less spritesheet we need to load)
• 👉 Also! It looks like we can get detected features from the KartaView API now too, so I'm trying to build this out in a way that's not Mapillary only.

[bhousel]

followup to above

The object icons are pretty bad, I will clean them up another time. We could really just map each of these detection categories to an OSM key/value and use the existing PresetSystem to pick reasonable icons. (Replacing the icons would also mean one less spritesheet we need to load)

☝️ I did this.. I mapped each detection type to a reasonable preset ID and now we can just use preset icons for these markers.

This is helpful too because if we ever do decide to allow mappers to add these features to OSM, it's easy to just create a point and assign a preset to it - all the tags will be set correctly.

For now I'm displaying them in the same "Mapillary green" color as the photo markers.
(@Bonkles said this looks very "Battlezone" haha)

old

new