facebook / Rapid

The OpenStreetMap editor driven by open data, AI, and supercharged features
https://rapideditor.org
ISC License
517 stars 91 forks source link

Overlapping detected objects need auto-spreading #1539

Open brian-luff opened 2 months ago

brian-luff commented 2 months ago

Description

Detected objects in Rapid are supposed to spread automatically when too close together. This is not happening.

Screenshots

image image

Version

2.4.0-pre.0

What browser are you seeing the problem on? What version are you running?

Firefox v130.0

The OS you're using

mac

Steps to reproduce

  1. Go to https://rapideditor.org/canary#map=21.76/40.65435/-74.52878&background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&photo_overlay=mapillary,mapillary-detections
  2. Zoom in and out on https://rapideditor.org/canary#map=22.30/40.65436/-74.52884&background=Bing&datasets=fbRoads,msBuildings&detection=mapillary-detections/469758280758179&disable_features=boundaries&photo=mapillary/766643124021324&photo_overlay=mapillary,mapillary-detections

The browser URL at the time you encountered the bug

https://rapideditor.org/canary#map=22.30/40.65436/-74.52884&background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&photo_overlay=mapillary,mapillary-detections

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:130.0) Gecko/20100101 Firefox/130.0

bhousel commented 1 month ago

In the screenshots it looks like they are moved apart a bit?

1516 was just to make sure that they are not in the exact same place that selecting them is impossible.

You will still need to zoom in if there are a lot of markers clumped together.

eneerhut commented 1 month ago

Behavior seems as expected to me in this example. Mapillary could do a better job merging these objects if they are the same utility pole, but that's not an issue for Rapid.