facebook / Rapid

The OpenStreetMap editor driven by open data, AI, and supercharged features
https://rapideditor.org
ISC License
524 stars 92 forks source link

Rapid roads dataset is not loading #1584

Open bos opened 1 month ago

bos commented 1 month ago

Description

Inferred roads are not showing up in my client. I assume this is due to a server outage, but I have no idea how to figure this out, or what the best way to report is.

Screenshots

No response

Version

2.4.0

What browser are you seeing the problem on? What version are you running?

No response

The OS you're using

No response

Steps to reproduce

Visit Rapid. No purple road bits.

The browser URL at the time you encountered the bug

https://rapideditor.org/edit#map=17.00/39.20809/-114.77681&background=EsriWorldImagery&datasets=fbRoads,msBuildings&disable_features=indoor,power

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

No response

Bonkles commented 1 month ago

Hey @bos! I can't personally repro this, as I've tried it on a couple of different OS/browser combos and all seems well.

I checked into the specific area you linked here (thanks for supplying the URL) and checked the back-end calls that we're making to obtain roads- they all succeeded, but all came up empty.

So, it would seem that the case is there's simply no data around here- but have you seen this other places as well? Specifically, have you seen it in some places before where now you're not getting any road shapes at all?

Bonkles commented 1 month ago

If you have time, can you go here and let me know if you get some buildings?

https://rapideditor.org/edit#map=17.60/44.51266/-99.99054&background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries

Here's what I see at this location: image

Scott169 commented 1 month ago

I met the same problem today. Here's an example area, the residential roads should be inferred:

image

By the way, when uploading the changeset, "mapwithai" and "maxar" tags are not automatically added as usual:

image

Version

2.4.0

What browser are you seeing the problem on? What version are you running?

Firefox ESR 128.3.1

The OS you're using

Windows 10

Bonkles commented 1 month ago

@Scott169 can you provide a URL of where you took that screenshot? That will better let me figure out if this is a server issue or not.

If you're not able to load the Rapid roads/building features, then you won't get the 'mapwithai' and 'maxar' tags on your changeset- those won't be added until you have added at least one road/building.

pieleric commented 1 month ago

@Bonkles, I am facing the same issue too: no road shown, anywhere in the world. The buildings show up fine (including the location you've suggested in comment https://github.com/facebook/Rapid/issues/1584#issuecomment-2415322740 ).

One area I know that used to show roads is this one: https://rapideditor.org/rapid#map=16.43/33.20938/107.54420&background=EsriWorldImagery&datasets=fbRoads,msBuildings

Now it looks like: image

Bonkles commented 1 month ago

I see, This is interesting then and more subtle than I had originally thought. So the service is displaying some features (buildings) and not others (roads), yet the roads requests are returning as 'successful' but empty. Generally when we see outages such as this, it's because the service has completely stopped working. I'll dig into this.

KataJing commented 1 month ago

Also met the same issue from about one week ago. Cannot see any roads including above hyperlinks. Seems something happen in source. I am also a mapwithai of JOSM user. The similar issue occurred, it showed server cannot connect.

Bonkles commented 1 month ago

Can confirm that one of our internal DBs has been impacted, causing the loss of our ability to serve roads. I'm working on repairing the infra, but no ETA yet on how long this will take.

Thank you all for the bug reports!

jjiglesiasg commented 1 month ago

Seems that this issue is more complex that originally thought. Not pushing, just good vibes so yo can deal with this somehow nightmare.

Bonkles commented 1 month ago

Yep, this one is proving tricky. Plus, one of the folks that can help us resolve the issue has been out sick for several days. Really unlucky timing, but still working on it.

bos commented 3 weeks ago

How's restoring the db coming along?

Bonkles commented 3 weeks ago

Not well, unfortunately. We have all the piece-parts we need to get the data flowing again, but there are a lot of gotchas to 'standing an existing DB scrape back up' vs. 'starting one from scratch'. We're just doing tons of waiting for assistance from internal infra groups, as we're a bit of an outlier case (in that we ship our data to a public endpoint).

Super frustrating and I wish it were going faster, but I'm still on this pushing on this as hard as I can each day.

bos commented 3 weeks ago

Thanks Ben, appreciate the persistence.

Bonkles commented 2 weeks ago

Update- we've had a couple nice breakthroughs with the data pipeline and the roads data is once again landing in a database from which we can serve. Next step is to migrate all the code references from the old, defunct database to this new one, test the changes in staging, and then roll out to production. Could be a few more days, but I'm on much firmer ground as to how to proceed from here.

Thanks all for your patience!

bos commented 2 weeks ago

That's great news! Mapping in the old school way, without these features, is certainly fun and calming, but it's soooo sloooow in comparison.

bos commented 2 weeks ago

I just now am seeing inferred roads show up!

Bonkles commented 2 weeks ago

Woohoo, I was hoping they'd start flowing by end-of-day, then I would make a triumphant post letting y'all know. So I guess this is that post. :-)

Scott169 commented 2 weeks ago

I saw the inferred roads. Confirmed that this issue is solved. Thanks a lot for your work.

jjiglesiasg commented 2 weeks ago

Looks like inferred roads are back. Reporting from #Bolivia. Congrats guys nice job to restore all these data.

Best Regards

jjiglesiasg commented 2 weeks ago

That's great news! Mapping in the old school way, without these features, is certainly fun and calming, but it's soooo sloooow in comparison.

True, but even without the inferred data, I feel that Rapid is like an ID on steroids, in particular in Power User mode