Possible extra node near connection

[pathexplorer]

Possible extra node near connection
Nodes around the connection may need to be moved or deleted.

when sending edits to the server, it issues many such warnings. They look pretty meaningless, since you absolutely can't see what is wrong. There is only one point, there are no others nearby. The question is solved by shifting the point to the side. And so all the time, sometimes 10-15 comments (in a package of 50 maximum during one session)

[tsmock]

I've a question for you:

• Do you have a good sample area you can link to (i.e., copy the URL of the page when you are at a location with this issue)

As a side note, in the JOSM MapWithAI plugin, I know I added some special casing to fix overnoded ways. It is possible that there are actual nodes near the connection, but I don't know what the threshold for RapiD is. For JOSM, I think I used 5m for untagged nodes, when it wouldn't change the geometry of the way by more than a certain amount.

Thanks, Taylor

[pathexplorer]

https://mapwith.ai/rapid#background=Mapbox&disable_features=landuse,boundaries,others&id=n-560784291438613&map=20.08/49.54803/27.88742 [image: image.png]

нд, 18 лип. 2021 о 13:46 Taylor Smock @.***> пише:

I've a question for you:

• Do you have a good sample area you can link to (i.e., copy the URL of the page when you are at a location with this issue)

As a side note, in the JOSM MapWithAI plugin, I know I added some special casing to fix overnoded ways. It is possible that there are actual nodes near the connection, but I don't know what the threshold for RapiD is. For JOSM, I think I used 5m for untagged nodes, when it wouldn't change the geometry of the way by more than a certain amount.

Thanks, Taylor

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/facebookincubator/RapiD/issues/269#issuecomment-882036578, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASNMAISG7UATELSZW3TOWZTTYKWGZANCNFSM5AROLABA .

-- Здравствуйте!

Профессиональный фотограф Станислав Набатников nabatnikov.com facebook.com/foton86 instagram.com/stas_nabatnikov 097 532 87 90 093 91 72 451

[tsmock]

If you tried to attach an image, something went wrong.

I took a look at that area, and I have this:

[pathexplorer]

I was getting a warning about the point to the right of the apex of the triangle. The main thing here is that I ignored this problem when saving. And now there are no warnings. But if they are not there - what was the problem?

пн, 19 лип. 2021 о 05:30 Taylor Smock @.***> пише:

If you tried to attach an image, something went wrong.

I took a look at that area, and I have this: [image: image] https://user-images.githubusercontent.com/45215054/126094309-d88aa1ee-579c-438f-b0c3-182c8e40f971.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/facebookincubator/RapiD/issues/269#issuecomment-882185819, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASNMAIW5BGZN2ITOE5Q4EOTTYOE3ZANCNFSM5AROLABA .

-- Здравствуйте!

Профессиональный фотограф Станислав Набатников nabatnikov.com facebook.com/foton86 instagram.com/stas_nabatnikov 097 532 87 90 093 91 72 451

[tsmock]

I'll ping @bhousel -- I think this might be present in upstream iD as well ( https://github.com/facebookincubator/RapiD/blame/main/modules/validations/close_nodes.js ).

[bhousel]

Looks like this error is being triggered by the y_shaped_connection validation, which is only in RapiD:

https://github.com/facebookincubator/RapiD/blob/36712f9516b3c2736b0690a6e2e07947687bdf81/data/core.yaml#L1957-L1961

The code for the validation is here: https://github.com/facebookincubator/RapiD/blob/main/modules/validations/y_shaped_connection.js

  /* We want to catch and warn about the following "shapes of connections"
     * that may appear in ML-generated roads:
     * (1) Two short edges around a connection node, causing a "Y-shaped" connection
     *     ________ _______
     *             V
     *             |
     *             |
     *             |
     * (2) One short edges around a connection node. The connection is not exactly
     * "Y-shaped", but still a little too detailed.
     *               _______
     *  ___________ /
     *             |
     *             |
     *             |
     * The potential fix is to remove the non-connection nodes causing the short edges,
     * so that the shape of the connection becomes more like a "T".
     *
     * This validation will flag issues on those excessive non-connection nodes around
     * Y-shaped connections and suggest deletion or move as possible fixes.
     * 
     * 

If you hover over a yellow warning box, it should highlight the issue on the map. I don't have any examples of this to look at right now, but we could maybe make the warning clearer?