facebook / Rapid

The OpenStreetMap editor driven by open data, AI, and supercharged features
https://rapideditor.org
ISC License
503 stars 92 forks source link

Improvements to custom map data feature #545

Open tordans opened 2 years ago

tordans commented 2 years ago

Description

(Let me know if you want this ticket in the iD repo rather than here. It looks like a "upstream" feature, but since custom data is kind of RapId's thing I thought it was better placed here.)

I tested the custom map data feature today and it has great potential for some QA projects we have in Berlin. (And IMO also for MapRoulette integration.)

Here are a few thinks I noticed, that could be improved…

The reuse of the "all tags" UI with the two column inputs and textarea is a bit rough.

image

Version

1.1.9

What browser are you seeing the problem on? What version are you running?

No response

Steps to reproduce

No response

The browser URL at the time you encountered the bug

https://mapwith.ai/rapid#background=custom:https://tiles.codefor.de/berlin-2022-dop20rgbi/{zoom}/{x}/{y}.png&datasets=https://parkraum.osm-verkehrswende.org/project-quality-assurance/berlin-parklets/gqis-for-maproulette.geojson&disable_features=boundaries&map=20.00/52.50050/13.40575&photo=&photo_dates=2021-01-01_&photo_overlay=mapillary


Ping https://github.com/facebook/RapiD/issues/585 because it's the same topic.

Bonkles commented 2 years ago

Thanks for submitting this @tordans! In the run-up to v2, we've started breaking tasks into individual, manageable chunks. I may 'check' one of these boxes and edit the line item to point to a separate bug.

Bonkles commented 1 year ago

Referencing https://github.com/facebook/Rapid/pull/1016 as being directly related to this issue.

tordans commented 1 year ago

@Bonkles FYI I updated the check list above since a few things are fixed in 2.1