facebook / Rapid

The OpenStreetMap editor driven by open data, AI, and supercharged features
https://rapideditor.org
ISC License
515 stars 91 forks source link

Mapillary Green is slightly off. #685

Closed Bonkles closed 1 year ago

Bonkles commented 1 year ago

Description

Code now has MAPILLARY_GREEN LISTED AS 0X55FF22, but this should be changed to 0x05cb63.

Version

2.00-alpha.3

What browser are you seeing the problem on? What version are you running?

Chrome v107.0

Steps to reproduce

Just enable the mapillary map points and check the difference in color. It's subtle!

image

(rapid on left, mapillary web site on right)

The browser URL at the time you encountered the bug

https://mapwith.ai/rapid-v2-alpha3#background=EsriWorldImageryClarity&datasets=fbRoads,msBuildings&disable_features=past_future,others&id=r1933745&map=21.15/42.37467/-71.11420&photo=mapillary/5839352752741830&photo_overlay=mapillary

Bonkles commented 1 year ago

Update: Spoke with @bhousel- reason for this color divergence is that he picked a slightly more contrasting green to pair with the Kartaview Blue and Bing Streetside Teal.

That said, here is a before (left) and after (right) comparison using the correct Mapillary color:

image

cbeddow commented 1 year ago

The contrast looks nice I would say... But checking the Mapillary website, the colors of buttons and such are actually #0bcb63 which might be a good choice then.

See this color too: mapillary_logo_green_1plate@2x

cbeddow commented 1 year ago

Same #0bcb63 here too... so let's give that a go? image

Bonkles commented 1 year ago

Fixed in 60bd5db76 but I am open to color suggestions.