facebook / Rapid

The OpenStreetMap editor driven by open data, AI, and supercharged features
https://rapideditor.org
ISC License
518 stars 91 forks source link

Upgrade to id-tagging-schema v6 #846

Closed bhousel closed 1 year ago

bhousel commented 1 year ago

Just tracking that I updated the preset code to add partial support for the id-tagging-schema v6 that was recently released.

Some things we don't support at this time:

I'll link back to this issue if/when we add more support for these things.

Work was done in these commits

bryceco commented 1 year ago

The Röntgen dependency is a PITA and really ridiculous. There's no way I'm adding all those prerequisites to my project, so for now I'm just copying them from iD from https://raw.githubusercontent.com/openstreetmap/iD/develop/svg/roentgen/*

Hopefully they fix this upstream.

tordans commented 1 year ago

FYI I created https://github.com/enzet/map-machine/issues/149 to track the issues of having the icons more easily consumed. I think there was no issue, yet, and it sounds like that really should be easier.

bhousel commented 1 year ago

Yes, I know I could copy the icons from the iD repo, but I really don't want the increased maintenance burden of looking there for new icons. For now these are the replacements I hardcoded:

https://github.com/facebook/RapiD/blob/0bef7fbea4a120201135335d39b7196564c8889f/modules/presets/index.js#L25-L37

bhousel commented 1 year ago

I just added the Röntgen icons in 589d43d78 .

The work I just completed on #925 gives us much more flexibility to support new spritesheets. These get converted to WebGL textures on the fly now, so we don't need to prepare a separate spritesheet for Pixi anymore.