Open Dcallies opened 2 weeks ago
Ref: https://realpython.com/python-type-self/
Since py-tx is a bit aged at this point, we've straddled a few quality of life improvements with typing.
We can replace a lot of forward-declared self references to Self instead.
Here's a command you could use to look for opportunities:
python-threatexchange# grep -r -n " -> [\"']" --include='*.py' .
Here's one file that comes up in that list: https://github.com/facebook/ThreatExchange/blob/main/python-threatexchange/threatexchange/signal_type/signal_base.py#L22
Hi @Dcallies , can I work on this?
It's all yours! Let me know if you don't think you won't be able to get to it in the next week!
Ref: https://realpython.com/python-type-self/
Since py-tx is a bit aged at this point, we've straddled a few quality of life improvements with typing.
We can replace a lot of forward-declared self references to Self instead.
Here's a command you could use to look for opportunities:
Here's one file that comes up in that list: https://github.com/facebook/ThreatExchange/blob/main/python-threatexchange/threatexchange/signal_type/signal_base.py#L22