facebook / ThreatExchange

Trust & Safety tools for working together to fight digital harms.
https://developers.facebook.com/docs/threat-exchange
Other
1.17k stars 321 forks source link

Fix the dangling `;` in installing vpdq #1691

Open ZeyadTarekk opened 4 hours ago

ZeyadTarekk commented 4 hours ago

https://github.com/facebook/ThreatExchange/blame/65c92ce52af208cf9cd1557df9d15937bd4c4ea7/vpdq/cpp/vpdq/cpp/hashing/ffmpegwrapper.cpp#L134

 INFO:setup.py:Compiling vpdqlib and pdqlib...
      CRITICAL:setup.py:/tmp/pip-install-mkatbfmh/vpdq_af861797f092467ca1b78712c95701e6/cpp/vpdq/cpp/hashing/ffmpegwrapper.cpp:130:62: error: extra ‘;’ [-Werror=pedantic]
        130 |     : m_frame(std::move(frame)), m_frameNumber(frameNumber){};
            |                                                              ^
      /tmp/pip-install-mkatbfmh/vpdq_af861797f092467ca1b78712c95701e6/cpp/vpdq/cpp/hashing/ffmpegwrapper.cpp:134:2: error: extra ‘;’ [-Werror=pedantic]
        134 | };
            |  ^
      cc1plus: all warnings being treated as errors
      gmake[2]: *** [vpdq/CMakeFiles/vpdqlib.dir/build.make:121: vpdq/CMakeFiles/vpdqlib.dir/cpp/hashing/ffmpegwrapper.cpp.o] Error 1
      gmake[1]: *** [CMakeFiles/Makefile2:186: vpdq/CMakeFiles/vpdqlib.dir/all] Error 2
      gmake: *** [Makefile:103: all] Error 2

      CRITICAL:setup.py:Failed to compile vpdq library.
ZeyadTarekk commented 4 hours ago

@ianwal Could you check that

ianwal commented 3 hours ago

Yep it's a typo. Semicolon should be removed. I'll fix this weekend or anyone else can. Feel free to make a PR for it.

Out of curiosity, are you able to see what compiler and compiler version that is detecting this? The CI doesn't pick this up, which uses a somewhat old GCC version, whatever is the default on its Ubuntu version.

ZeyadTarekk commented 3 hours ago

@ianwal gcc version 10.2.1 20210110 (Debian 10.2.1-6)

I have create a PR to solve it