search

facebook / ThreatExchange

Trust & Safety tools for working together to fight digital harms.
https://developers.facebook.com/docs/threat-exchange
Other
1.16k stars 307 forks source link

Provide default java implementation for TMK #210

Open lfcnassif opened 4 years ago

lfcnassif commented 4 years ago

Hello,

Like there is a default java implementation for PDQ, I think it makes sense having one for TMK. Maybe a JNI/JNA wrapper may be sufficient.

johnkerl commented 4 years ago

Thanks! Another partner has asked for this as well ... at present we're looking to schedule time to do the port. Java is always a popular language for folks to use! :)

github-actions[bot] commented 3 years ago

This issue is being marked as stale because it has no recent activity. It will be closed automatically in 14 days unless it becomes active before then. To prevent closing, please comment on the issue before that time. If the issue is no longer relevant, please feel free to close it prior to that time.

Cleaning up stale issues helps redirect focus to the issues top of mind of the community. Thank you for your help with this.

lfcnassif commented 3 years ago

I still think it could be useful. Thanks for the project. Unfortunatelly I currently don't have time to contribute...

bodnarbm commented 3 years ago

Thanks for updating, @lfcnassif! I am not sure when our team will be able to work on porting the code to java, but I will mark this issue with a help-wanted tag in case anyone with free cycles is interested in doing the port (likely through a JNI or JNA wrapper as you suggested). Really appreciate the suggestion and update.

BigPanda97 commented 2 years ago

I agree here, a Java implementation of TMK would be really nice. It is requested for nearly 2 years now…