facebook / akd

An implementation of an auditable key directory
Apache License 2.0
243 stars 36 forks source link

Adding key history validation checks #417

Closed kevinlewi closed 1 year ago

kevinlewi commented 1 year ago

Adds error-handling for various edge-cases when performing key history verification

codecov-commenter commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (86365d6) 87.78% compared to head (04116e7) 87.90%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #417 +/- ## ========================================== + Coverage 87.78% 87.90% +0.11% ========================================== Files 39 39 Lines 8951 9054 +103 ========================================== + Hits 7858 7959 +101 - Misses 1093 1095 +2 ``` | [Files](https://app.codecov.io/gh/facebook/akd/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=facebook) | Coverage Δ | | |---|---|---| | [akd\_core/src/verify/history.rs](https://app.codecov.io/gh/facebook/akd/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=facebook#diff-YWtkX2NvcmUvc3JjL3ZlcmlmeS9oaXN0b3J5LnJz) | `89.24% <100.00%> (+2.23%)` | :arrow_up: | | [akd/src/tests.rs](https://app.codecov.io/gh/facebook/akd/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=facebook#diff-YWtkL3NyYy90ZXN0cy5ycw==) | `95.68% <98.66%> (+0.21%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/facebook/akd/pull/417/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=facebook)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.