facebook / akd

An implementation of an auditable key directory
Apache License 2.0
233 stars 35 forks source link

Fixing prefix-checking comment in non-membership proof verification #419

Closed kevinlewi closed 10 months ago

kevinlewi commented 10 months ago

The comment for this check was backwards -- it should be that we are checking that proof.longest_prefix is a prefix of the proof's label. (The code was correct, the comment wasn't)

codecov-commenter commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (85beb07) 87.89% compared to head (318d708) 87.90%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #419 +/- ## ========================================== + Coverage 87.89% 87.90% +0.01% ========================================== Files 39 39 Lines 9054 9054 ========================================== + Hits 7958 7959 +1 + Misses 1096 1095 -1 ``` | [Files](https://app.codecov.io/gh/facebook/akd/pull/419?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=facebook) | Coverage Δ | | |---|---|---| | [akd\_core/src/verify/base.rs](https://app.codecov.io/gh/facebook/akd/pull/419?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=facebook#diff-YWtkX2NvcmUvc3JjL3ZlcmlmeS9iYXNlLnJz) | `91.62% <50.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/facebook/akd/pull/419/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=facebook)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.