search

facebook / akd

An implementation of an auditable key directory
Apache License 2.0
233 stars 35 forks source link

Implemented AsyncInMemoryDatabase::set in terms of ::batch_set #425

Closed cryo28 closed 6 months ago

cryo28 commented 6 months ago

The implementation of AsyncInMemoryDatabase::set and batch_set contain a lot of duplicate code.

Tested with:

cargo test test_in_memory_db
codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.43%. Comparing base (24b11de) to head (d759c17).

Files Patch % Lines
akd/src/storage/memory.rs 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #425 +/- ## ========================================== + Coverage 87.99% 88.43% +0.43% ========================================== Files 39 39 Lines 9054 9198 +144 ========================================== + Hits 7967 8134 +167 + Misses 1087 1064 -23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kevinlewi commented 6 months ago

Sorry, I landed #426 first which also fixed the clippy error -- can you rebase on main and force-push again? Should fix the CI issue

cryo28 commented 6 months ago

It seems like force updates don't re-trigger workflows. Not sure what I should do? Should I recreate the PR or add some dummy commit to the existing one?