facebook / akd

An implementation of an auditable key directory
Apache License 2.0
246 stars 36 forks source link

Only instantiate storage metrics when runtime_metrics is enabled #435

Closed afterdusk closed 5 months ago

afterdusk commented 5 months ago

Only instantiate metrics attribute in storage manager when the runtime_metrics feature is enabled. This avoids an unnecessary import of atomic types, which not all architectures support.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.90%. Comparing base (3ce5335) to head (61a19d1). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #435 +/- ## ========================================== + Coverage 88.61% 88.90% +0.28% ========================================== Files 39 39 Lines 9109 9228 +119 ========================================== + Hits 8072 8204 +132 + Misses 1037 1024 -13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.