search

facebook / buck

A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.
https://buck.build
Apache License 2.0
8.56k stars 1.16k forks source link

`prebuilt_apple_framework` doesn't copy dynamic libraries into bundle #2058

Open ghvg1313 opened 6 years ago

ghvg1313 commented 6 years ago

I noticed that the commit was reverted with the comment saying it breaks internal build. Is there anything we can do to fix the issue and get this feature back? Or is there any plan there to support this feature in the future?

thedavidharris commented 5 years ago

Is there any workaround for this? Getting the usual Library not loaded: @rpath/MyFramework.framework/MyFramework errors.

acecilia commented 5 years ago

Looks like a workaround is to add the dependency also as test dependency. See: https://github.com/airbnb/BuckSample/blob/master/Libraries/SwiftWithPrecompiledDependency/BUCK

acecilia commented 5 years ago

There was a PR that was merged fixing it, and then it was reverted: https://github.com/airbnb/BuckSample/pull/66#issuecomment-480394699

Any idea why?

EDIT: a comment mentioning why: https://github.com/facebook/buck/issues/1339#issuecomment-533252658