Problem with installation via homebrew

facebook / buck

A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.

https://buck.build

Apache License 2.0

8.56k stars 1.16k forks source link

Problem with installation via homebrew #2579

Open wesade opened 3 years ago

wesade commented 3 years ago

rajyengi commented 3 years ago

Is this on BigSur? I believe some dependencies need to be updated first (https://github.com/facebook/buck/pull/2580)

wesade commented 3 years ago

What do you mean by BigSur?

hasayakey commented 3 years ago

need java 11 but homebrew formula add java 8 depency

hasayakey commented 3 years ago

edit /usr/local/Homebrew/Library/Taps/facebook/homebrew-fb/buck.rb update line 20 to "openjdk@11"

moshiba commented 3 years ago

need java 11 but homebrew formula add java 8 depency

@wesade opened this issue 11 days ago, at then the latest release is v2020.10.21.01, I built it from source using the formula with openjdk@8 on BigSur without problem, so probably something else was off.

moshiba commented 3 years ago

Actually according to the latest stable release: v2021.01.12.01, looking at the CI config: https://github.com/facebook/buck/blob/v2021.01.12.01/.circleci/config.yml#L54 It suggests that even now buck is buildable using openjdk8

lexaurin commented 3 years ago

I can reproduce it on macOS Catalina (10.15.7).

When I have adoptopenjdk-14 installed along with older java version it produces error mentioned. My JAVA_HOME is set to /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home version and ant -diagnostics shows java.version : 1.8.0_282..

But once I remove version java 14 then it installs ok. Seems like installation script ignores JAVA_HOME.

moshiba commented 3 years ago

I can reproduce it on macOS Catalina (10.15.7).

When I have adoptopenjdk-14 installed along with older java version it produces error mentioned. My JAVA_HOME is set to /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home version and ant -diagnostics shows java.version : 1.8.0_282..

But once I remove version java 14 then it installs ok. Seems like installation script ignores JAVA_HOME.

My bad, I realized that my environment was actually a bit messy. I have adoptopenjdk-8 installed (the old docs used to recommend this), and openjdk@8 installed (I suppose it has to do with Homebrew's new policy about casks being dependencies?), with all those installed my build was fine.

Anyway, @lexaurin, about your case, may I recommend a probably related PR: https://github.com/facebook/homebrew-fb/pull/52 ?