Closed uKetki closed 3 years ago
Hi @uKetki!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
windows_tests
seem unrelated.
The commit addresses the below changes:
Adding BinaryType enum to segregate apk and aab flow
Looking at the buck code for generating apk and aab, it is evident that
AndroidBinaryBuildable
is bloated with a lot of responsibilities ranging from apk/aab generation, signing to optimization.The overview of current buck architecture:
The suggestion is to refactor existing code and create two separate layers: Optimizers and Buildable which can re-use the common logic for binary generation and offload the specific implementation to the respective layers:
This approach will later help to add changes needed to support dynamic feature delivery.