search

facebook / buck

A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.
https://buck.build
Apache License 2.0
8.56k stars 1.16k forks source link

[APPLE][WIP] XCFrameworks Support #2593

Open Lcsmarcal opened 3 years ago

Lcsmarcal commented 3 years ago

Related to (#2594)

rajyengi commented 3 years ago

Sorry for letting this stagnate @Lcsmarcal, do you mind rebasing? The circleci configs got updated to fix these jdk install failures that the circle ci jobs on your PR are failing on.

Lcsmarcal commented 3 years ago

Done @rajyengi. This PR is a work in progress, it can improved with buck developers (or the community itself) code review.

Edit: as a WIP, I didn't fix/write the integration tests. I can fix it if you want :)

KapJI commented 3 years ago

Yeah, I'd be great to have some tests for this new feature.

And that RustBinaryIntegrationTest is very flaky, if you can fix it (in a separate PR), I'll really appreciate that 🙂

KapJI commented 3 years ago

@Lcsmarcal is it still WIP?

Thomvis commented 2 years ago

It would be great to get this merged. Anything I can help make that happen?