Open Lcsmarcal opened 3 years ago
Sorry for letting this stagnate @Lcsmarcal, do you mind rebasing? The circleci configs got updated to fix these jdk install failures that the circle ci jobs on your PR are failing on.
Done @rajyengi. This PR is a work in progress, it can improved with buck developers (or the community itself) code review.
Edit: as a WIP, I didn't fix/write the integration tests. I can fix it if you want :)
Yeah, I'd be great to have some tests for this new feature.
And that RustBinaryIntegrationTest
is very flaky, if you can fix it (in a separate PR), I'll really appreciate that 🙂
@Lcsmarcal is it still WIP?
It would be great to get this merged. Anything I can help make that happen?
Related to (#2594)