facebook / buck

A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.
https://buck.build
Apache License 2.0
8.56k stars 1.16k forks source link

[apple] Stop propagating underlying libraries when using resources_from_deps. #2600

Open yanks opened 3 years ago

yanks commented 3 years ago

We observed that the resources_from_deps would propagate linkables for the transitive dependencies into a resultant binary. With this change, resources_from_deps will only include resources, not the actual linkable results.

KapJI commented 3 years ago

For some reason CircleCI jobs haven't been triggered. Can you try to push something to make them run?

KapJI commented 3 years ago

@yanks can you please follow these steps to make CI jobs running?

https://github.com/facebook/buck/pull/2611#issuecomment-819784681