search

facebook / buck

A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.
https://buck.build
Apache License 2.0
8.56k stars 1.16k forks source link

Incorrect version number in Buck v2021.01.12.01 #2607

Open swarren12 opened 3 years ago

swarren12 commented 3 years ago

It appears that the output of ./buck --version is wrong in v2021.01.12.01, as it reports itself as being v2020.09.01.01.

I believe that this is because the .buckrelease file hasn't been updated?

Steps to reproduce:

  1. Download the v2021.01.12.01 .zip / .tar.gz
  2. Run buck build --show-output buck
  3. Run the generated .pex file with the --version flag:
$ wget https://github.com/facebook/buck/archive/refs/tags/v2021.01.12.01.tar.gz
$ tar xf v2021.01.12.01.tar.gz
$ cd buck-2021.01.12.01/
$ buck build --show-output buck
  ...
  //programs:buck buck-out/gen/ce9b6f2e/programs/buck.pex 
$ buck-out/gen/ce9b6f2e/programs/buck.pex --version
  buck version v2020.09.01.01

It seems a fairly trivial thing to fix, but given that this has already been released and I'd expect that a change, even one like this, would result in a new version number, I'm not sure what the desired approach to a fix would be.

KapJI commented 3 years ago

Hi! Thanks for pointing out at this, we need to make sure to set the correct .buckrelease for the next version.

swarren12 commented 3 years ago

:+1: thanks!

For what it's worth, it appears the version number inside the .deb package is correct - maybe it's only building from source that's affected?

KapJI commented 3 years ago

I think so. Other packages are built with https://github.com/facebook/buck/blob/master/tools/release/publish_release.py and it sets the version correctly.