Closed uKetki closed 3 years ago
All test cases are failing due to the below error. However, if I don't see this issue locally and test cases are working as expected. Are there any changes required either on CI or from code to support this use case?
stderr: /home/circleci/buck/test/com/facebook/buck/android/AndroidAppBundleIntegrationTest.java:41: error: cannot find symbol
import com.facebook.buck.util.MoreStringsForTests;
^
symbol: class MoreStringsForTests
location: package com.facebook.buck.util
Errors: 1. Warnings: 0.
When running <source_abi>.
When building rule //test/com/facebook/buck/android:app-bundle-integration#source-abi,testsjar.
@uKetki you probably need to update BUCK file and add new dependency there.
@uKetki you probably need to update BUCK file and add new dependency there.
Thanks, @KapJI. Added dependency for //test/com/facebook/buck/util:testutil
in app-bundle-integration
test.
NDK 17 failed tests look relevant.
NDK 17 failed tests look relevant. Do I need to include kotlin_home in a different way?
Overridden kotlin:kotlin_home path not found: kotlinc When creating rule //kotlin/com/sample/dynamic_features/on_demand:src_release.
Setup kotlinc path in the test workspace. The current failed cases seem unrelated.
TESTS FAILED: 1 FAILURE
Failed target: //test/com/facebook/buck/rules/modern/builders:builders
FAIL com.facebook.buck.rules.modern.builders.HybridLocalStrategyTest
Thanks! 🎉
Thanks for merging the PR, @KapJI!
Added test cases and prepared test data for dynamic feature module. Each feature has distinctly unique characteristics explained as follows:
kotlin
-> Feature written in Kotlin and will be available on-demandjava
-> Feature written in Java and will be available conditionally at install-time for devices with minsdk=21 and maxSdk=24native
-> Feature written in Java using JNI and will be available on-demandinitialInstall
-> Feature written in Java and will be available at install-timeDepends on #2586