facebook / buck

A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.
https://buck.build
Apache License 2.0
8.56k stars 1.16k forks source link

[docs] Fix instructions for Java install with Homebrew #2611

Closed narlei closed 3 years ago

narlei commented 3 years ago

The current doc use homebrew/cask-cask instructions, and cask was changed.

The current instructions to install java with Homebrew doesn't work, and mysteriously it requests your github email and password 🤔🏴‍☠️. This PR change the docs to install java using https://github.com/AdoptOpenJDK/homebrew-openjdk with correct cask command in homebrew.

KapJI commented 3 years ago

Not sure why CI is not triggered :( Can you try to force push to trigger it?

Lcsmarcal commented 3 years ago

@KapJI It's happening with another PRs too :(

narlei commented 3 years ago

I tried force push but still not triggering the CI. As @Lcsmarcal says, It's happening with other PRs too.

KapJI commented 3 years ago

Might be related to https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization-

narlei commented 3 years ago

Thank you @KapJI

The complete guide:

The solution for circle-ci checks not running in PRs: https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization-

By steps:

1 - Go to Signup - CircleCI and sign up with your Github account. 2 - Will be listed all your repos, go to your buck fork, if you are following it, a button “Unfollow” will be showed, just Unfollow and jump to step 5, if not, a “Set Up Project“ button appears, let’s Set Up. 3 - After Setup the project, go back to the “Projects” page (https://app.circleci.com/projects/project-dashboard/github/YOUR_USERNAME_HERE/) 4 - Just Unfollow the project. 5 - Go to https://app.circleci.com/pipelines/github/facebook/buck 6 - At the right bottom screen will appear a “Follow project” button, just follow. 7 - Give a push —force in your project fork. Done, go to https://app.circleci.com/pipelines/github/facebook/buck and see your PR running.

KapJI commented 3 years ago

@narlei Thanks a lot for figuring this out! CircleCI is very confusing.

We probably should migrate to Github Actions but these CI definitions are large and we need someone to do that.