Add friend path ABI jars as required deps of Kotlin libraries

facebook / buck

A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.

https://buck.build

Apache License 2.0

8.56k stars 1.16k forks source link

Add friend path ABI jars as required deps of Kotlin libraries #2616

Closed jbarr21 closed 3 years ago

jbarr21 commented 3 years ago

In some cases, the Kotlin ABI jar for a dependency may not be already generated in the task graph, so when it is used as a friend path, it does not get picked up. This ensures that if a module is used as a friend path, that we add an explicit dependency on calculating its ABI jar so that we can use its absolute path in the friend path Kotlin compiler arg.

Resolves #2614

KapJI commented 3 years ago

Please follow instruction in https://github.com/facebook/buck/pull/2611#issuecomment-819784681 to enable CircleCI testing.

KapJI commented 3 years ago

Thanks! 🎉