search

facebook / buck

A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.
https://buck.build
Apache License 2.0
8.56k stars 1.16k forks source link

Incorrect class-abi for Kotlin 1.5.0 #2620

Open rybalkinsd opened 3 years ago

rybalkinsd commented 3 years ago

Why? Buck can not read Kotlin 1.5.0 metadata. KotlinClassMetadata.read() returns null trying to parse 1.5.0 source file. -KotlinMetadataReader.java

Reproduce:

  1. Update kotlin-compiler to 1.5.0
  2. Update kotlin-stdlib to 1.5.0 [optional]
  3. Run StubJarTest#kotlinClassWithInlineMethod

How to fix:

  1. Add assertion to metadata reader
  2. Update kotlinx-metadata-jvm : 0.1.0 -> 0.3.0
KapJI commented 3 years ago

Can you submit a PR to update kotlinx-metadata-jvm? 🙂

rybalkinsd commented 3 years ago

Fixed, should we close?

KapJI commented 3 years ago

Internal changes are going to dev branch only. Do we need to fix this on master?