Closed swarren12 closed 2 years ago
Hi @swarren12!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
Thanks!
As discussed in #2623, this change will use the original test class name instead of the test suite name when generating the test output XML when run against a JUnit suite.
I've tried to keep the change as small as possible by overloading the
TestCaseSummary
constructor to default the newtestSuite
parameter tofalse
, so that all the other usages of this aren't affected, but if it's better to push this default up to the places where this class is instantiated then I can do that instead!One thing that CI pointed out to me was that changing the shape of
TestCaseSummary
caused a unit test to fail because there are checks on how this object serialises. I've updated that test, but I'm not familiar with what the actual implications of changing this are and whether that suggests that maybe I should be achieving this result in a different way.Also, one CI job is failing but I don't believe that's related to my change.