CI: remove deprecated NDK 15, 16, 17 - Githubissues

facebook / buck

A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.

https://buck.build

Apache License 2.0

8.56k stars 1.16k forks source link

CI: remove deprecated NDK 15, 16, 17 #2658

Closed dulmandakh closed 2 years ago

dulmandakh commented 2 years ago

Let's remove long deprecated NDK versions from CI to make contributions easy and faster. I would like to work on NDK 23 support for React Native. IMHO, supporting LTS versions would be enough for most developers.

15 - Jun 9, 2017 - https://github.com/android/ndk/wiki/Changelog-r15
16 - Nov 15, 2017 - https://github.com/android/ndk/wiki/Changelog-r16
17 - May 9, 2018 - https://github.com/android/ndk/wiki/Changelog-r17

dulmandakh commented 2 years ago

@KapJI could you please review and help with macos_test_integration. Feel free to merge.

dulmandakh commented 2 years ago

@cortinico please review and merge

dulmandakh commented 2 years ago

@cortnico CI is failing due to SSL issue, which is not related to the change

cortinico commented 2 years ago

I don't think this is strictly needed, but I'll leave the decision to @rajyengi on how to proceed. If you rebase, the CI should be green anyway.

dulmandakh commented 2 years ago

These NDK versions are deprecated a long time ago, and no longer supported. Main concern is it's making CI slow.

cortinico commented 2 years ago

Agree that those versions are old. NDK 17 is still used internally though I believe.

Main concern is it's making CI slow.

All the NDK versions tests are executed in parallel so I don't believe is a major problem in terms of CI speed. The concern is more on maintenance costs