search

facebook / buck

A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.
https://buck.build
Apache License 2.0
8.56k stars 1.16k forks source link

Add support for M1 chips #2684

Open marcesengel opened 2 years ago

marcesengel commented 2 years ago

Fixes #2666. Updated jna, java-objc-bridge, sqlite-jdbc and zstd-jni to supported versions.

Breaks java 8 support due to bumping java-objc-bridge, see https://github.com/shannah/Java-Objective-C-Bridge/issues/41#issuecomment-795362552.

Solace-Studios commented 2 years ago

@marcesengel Hey Marc, what java version should I use with this while Facebook works on merging this?

cortinico commented 2 years ago

Hey @marcesengel I would love to see this moving forward.

Could you update the CircleCI config to install JDK 11: https://github.com/facebook/buck/blob/16dc4866c20e807451a1762eb98776814c545e6f/.circleci/config.yml#L47-L57

and update the JAVA_HOME version in the CircleCI config, like here:

https://github.com/facebook/buck/blob/main/.circleci/config.yml#L200

To point to JDK 11?

bigfootjon commented 1 year ago

@marcesengel are you still working on this? Or would you mind if someone else took this over?

marcesengel commented 1 year ago

This PR only allows us to build on M1 IIRC, not sure if everything works with that build though - I still had some issues building react-native with the resulting build of buck.

I'd be open to pass this on, as it sadly wasn't getting any contributor traction when I had the time and need to add support (which I can understand, people have a life outside open source).

cortinico commented 1 year ago

I'd be open to pass this on, as it sadly wasn't getting any contributor traction when I had the time and need to add support (which I can understand, people have a life outside open source).

Totally understand :) I'll take this over then 🙏

cortinico commented 1 year ago

Totally understand :) I'll take this over then 🙏

Just a heads up that I won't have capacity to do this one. I looked into it but it's harder than expected + we dropped support for Buck 1 OSS on React Native as we're looking into potentially adopting Buck 2