Open marcesengel opened 2 years ago
@marcesengel Hey Marc, what java version should I use with this while Facebook works on merging this?
Hey @marcesengel I would love to see this moving forward.
Could you update the CircleCI config to install JDK 11: https://github.com/facebook/buck/blob/16dc4866c20e807451a1762eb98776814c545e6f/.circleci/config.yml#L47-L57
and update the JAVA_HOME
version in the CircleCI config, like here:
https://github.com/facebook/buck/blob/main/.circleci/config.yml#L200
To point to JDK 11?
@marcesengel are you still working on this? Or would you mind if someone else took this over?
This PR only allows us to build on M1 IIRC, not sure if everything works with that build though - I still had some issues building react-native with the resulting build of buck.
I'd be open to pass this on, as it sadly wasn't getting any contributor traction when I had the time and need to add support (which I can understand, people have a life outside open source).
I'd be open to pass this on, as it sadly wasn't getting any contributor traction when I had the time and need to add support (which I can understand, people have a life outside open source).
Totally understand :) I'll take this over then 🙏
Totally understand :) I'll take this over then 🙏
Just a heads up that I won't have capacity to do this one. I looked into it but it's harder than expected + we dropped support for Buck 1 OSS on React Native as we're looking into potentially adopting Buck 2
Fixes #2666. Updated
jna
,java-objc-bridge
,sqlite-jdbc
andzstd-jni
to supported versions.Breaks java 8 support due to bumping
java-objc-bridge
, see https://github.com/shannah/Java-Objective-C-Bridge/issues/41#issuecomment-795362552.