search

facebook / buck

A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.
https://buck.build
Apache License 2.0
8.56k stars 1.16k forks source link

Update ASM from 7.1 to 9.2 #2690

Open patosai opened 2 years ago

patosai commented 2 years ago

Got a stack trace when using Java 17:

java.lang.IllegalArgumentException: Unsupported class file major version 59
java.lang.IllegalArgumentException: Unsupported class file major version 59
    at org.objectweb.asm.ClassReader.<init>(ClassReader.java:195)
    at org.objectweb.asm.ClassReader.<init>(ClassReader.java:176)
    at org.objectweb.asm.ClassReader.<init>(ClassReader.java:162)
    at org.objectweb.asm.ClassReader.<init>(ClassReader.java:283)
    at com.facebook.buck.jvm.java.abi.DirectoryReader.visitClass(DirectoryReader.java:65)
    at com.facebook.buck.jvm.java.abi.JarReader.visitClass(JarReader.java:53)
    at com.facebook.buck.jvm.java.abi.StubJarClassEntry.of(StubJarClassEntry.java:106)
    at com.facebook.buck.jvm.java.abi.StubJarEntry.of(StubJarEntry.java:37)
    at com.facebook.buck.jvm.java.abi.StubJar.writeTo(StubJar.java:107)
    at com.facebook.buck.jvm.java.abi.StubJar.writeTo(StubJar.java:85)
    at com.facebook.buck.jvm.java.CalculateClassAbiStep.execute(CalculateClassAbiStep.java:51)
    at com.facebook.buck.step.StepRunner.runStep(StepRunner.java:58)
    at com.facebook.buck.core.build.engine.impl.CachingBuildRuleBuilder$BuildRuleSteps.executeCommands(CachingBuildRuleBuilder.java:1417)
    at com.facebook.buck.core.build.engine.impl.CachingBuildRuleBuilder$BuildRuleSteps.runWithDefaultExecutor(CachingBuildRuleBuilder.java:1394)
    at com.facebook.buck.util.concurrent.WeightedListeningExecutorService.lambda$submit$2(WeightedListeningExecutorService.java:100)
    at com.facebook.buck.util.concurrent.WeightedListeningExecutorService.lambda$submitWithSemaphore$0(WeightedListeningExecutorService.java:74)
    at com.google.common.util.concurrent.AbstractTransformFuture$AsyncTransformFuture.doTransform(AbstractTransformFuture.java:206)
    at com.google.common.util.concurrent.AbstractTransformFuture$AsyncTransformFuture.doTransform(AbstractTransformFuture.java:195)
    at com.google.common.util.concurrent.AbstractTransformFuture.run(AbstractTransformFuture.java:115)
    at com.google.common.util.concurrent.MoreExecutors$5$1.run(MoreExecutors.java:999)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:748)

  Updating ASM to the latest version (9.2) fixed it for me. I got the JARs from the site listed in third-party/java/asm/README