Closed bigfootjon closed 2 years ago
Cherry-picked from https://github.com/facebook/buck/commit/1ae1e6c078255529930a31e49f55e5bfff7b9d3f (#2696)
Fixes: https://github.com/facebook/buck/issues/2678
Test plan:
I ran buck for a personal project that uses py3.10 syntax (Foo | None) and it was able to build and run correctly
buck
Foo | None
Original commit message:
On 3.10 some collections classes have been moved to collections.abc and it causes Buck 1 to crash. This diff fixes those instances.
collections
collections.abc
Really pex should be upgraded, but I made an attempt and it was very difficult due to our custom changes to pex.
Reviewed By: bigfootjon
fbshipit-source-id: 15a7bb96e664d5169b12de09e9157571782c861f
Cherry-picked from https://github.com/facebook/buck/commit/1ae1e6c078255529930a31e49f55e5bfff7b9d3f (#2696)
Fixes: https://github.com/facebook/buck/issues/2678
Test plan:
I ran
buckfor a personal project that uses py3.10 syntax (Foo | None) and it was able to build and run correctlyOriginal commit message:
On 3.10 some
collectionsclasses have been moved tocollections.abcand it causes Buck 1 to crash. This diff fixes those instances.Really pex should be upgraded, but I made an attempt and it was very difficult due to our custom changes to pex.
Reviewed By: bigfootjon
fbshipit-source-id: 15a7bb96e664d5169b12de09e9157571782c861f