search

facebook / buck

A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.
https://buck.build
Apache License 2.0
8.56k stars 1.16k forks source link

Attempt to fix dev branch CircleCI #2713

Closed egpast closed 2 years ago

egpast commented 2 years ago

Currently, all dev publish_docs jobs are failing the Java 11 requirement (https://github.com/facebook/buck/blob/dev/build.xml#L365-L367 ).

This commit copies over Homebrew syntax from the main branch and swaps 8s for 11s (I've quickly confirmed that the new JDK identifiers actually exist).

I have not tested this - not sure whether it's possible to do so without actually making a pick request.

facebook-github-bot commented 2 years ago

Hi @egpast!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!