search

facebook / buck

A fast build system that encourages the creation of small, reusable modules over a variety of platforms and languages.
https://buck.build
Apache License 2.0
8.56k stars 1.16k forks source link

fix testng requiring annotations to set alwaysRun=true #2723

Closed adolfojunior closed 2 years ago

adolfojunior commented 2 years ago

Summary: TestNG tests using Before/After annotations requires to be set alwaysRun=true, because a Filter disable the annotations preventing it to be executed when TestRunner is executing with --filter It's an issue that projects on fbcode live with, but onboarding projects that use testng from maven/gradle will break.

This fix will allow Presto to start using buck.

Reviewed By: ericyuliu

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D38760845