search

facebook / buck2

Build system, successor to Buck
https://buck2.build/
Apache License 2.0
3.53k stars 215 forks source link

Fixed the example hello_world library generation. #501

Closed jhdub23 closed 10 months ago

jhdub23 commented 10 months ago

The "print" library incorrectly included the main.cpp file in its list of sources. The main.cpp file should be used only as a source for the final executable.

This resolves issue #480.

facebook-github-bot commented 10 months ago

Hi @jhdub23!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 10 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

ndmitchell commented 10 months ago

Thanks for the fix!

facebook-github-bot commented 10 months ago

@ndmitchell has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.